Merge pull request #352 from mdoggydog/navmenu-title-on-a

Move 'title' attribute of NavMenu toggles to the <a> elements
ProfessionalWiki · Oct 4, 2022 · 285c909 · 285c909
2 parents 8117b02 + ac6a850
commit 285c909
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Components/NavMenu.php b/src/Components/NavMenu.php
@@ -155,12 +155,12 @@ protected function buildDropdownMenuStub( $menuDescription ) {
 		return $this->indent() . \Html::rawElement( 'div',
 				[
 					'class' => 'nav-item ' . $menuId . '-dropdown',
-					'title' => Linker::titleAttrib( $menuId )
 				],
 				\Html::rawElement( 'a',
 					[
 						'href' => '#',
 						'class' => 'nav-link ' . $menuId . '-toggle',
+						'title' => Linker::titleAttrib( $menuId ),
 					],
 					htmlspecialchars( $menuDescription['header'] ) )
 			);
@@ -179,7 +179,6 @@ protected function buildDropdownOpeningTags( $menuDescription ) {
 		$ret = $this->indent() . \Html::openElement( 'div',
 				[
 					'class' => 'nav-item dropdown ' . $menuId . '-dropdown',
-					'title' => Linker::titleAttrib( $menuId ),
 				] );
 
 		// add the dropdown toggle
@@ -190,6 +189,7 @@ protected function buildDropdownOpeningTags( $menuDescription ) {
 					'class' => 'nav-link dropdown-toggle ' . $menuId . '-toggle',
 					'data-toggle' => 'dropdown',
 					'data-boundary' => 'viewport',
+					'title' => Linker::titleAttrib( $menuId ),
 				],
 				htmlspecialchars( $menuDescription['header'] ) );