[DNM] add tilesurl option for leaflet map #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm somewhat concerned about security implications. Like this people can have images that they control be pulled in. And record what users are doing with the maps based on the requests. Perhaps such things are already possible using other features of Maps? I don't recall. Having this be disabled by default and requiring the site owners to opt-in would certainly ease my mind. |
|
Ah, haven't thought about that. |
PeterTheOne
changed the title
|
I will change this and make it work more like the layers in the openlayers service. |
|
Collected some conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #92
I don't have access to an alternative tile source, but as far as I know this should work.