New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link to markercluster resource #139

Closed

kghbln wants to merge 1 commit into master from issue138

Member

kghbln commented May 17, 2016

Fix location of markercluster files. Refs issue #138

New code location according to: stackoverflow - 37179980
Code link set according to: stackoverflow - 17341122


          Update link to markercluster resource

ec6bb3f

Refs #138

New code location according to:
http://stackoverflow.com/questions/37179980/markercluster-v3-stopped-working-properly?answertab=votes#tab-top

Code link set according to:
http://stackoverflow.com/questions/17341122/link-and-execute-external-javascript-file-hosted-on-github/18049842#18049842

Contributor

PeterTheOne commented May 17, 2016 •

edited by kghbln

Loading

The m*.png images should be included in Maps, because GitHub is not a CDN and we may have the same problem in the future if we link to it.

Contributor

PeterTheOne commented May 17, 2016

Actually we should not change the constant but pass the local imagePath in https://github.com/JeroenDeDauw/Maps/blob/637e120d81681ed71646ddeb2e85cb9be2ef06d4/includes/services/GoogleMaps3/jquery.googlemap.js#L620 as seen in https://github.com/googlemaps/js-marker-clusterer/blob/2f659a3c288cdb8dfd1940b00080ff31863b08bc/src/markerclusterer.js#L122 .

Member Author

kghbln commented May 17, 2016

This would be a follow up commit I believe.

Member

JeroenDeDauw commented May 17, 2016

So stuff can break if they change what is on the gh-pages branch of their repo? Seems like a bad idea if there is no stability guarantee

Member Author

kghbln commented May 17, 2016

So stuff can break

That's the situation we had during the past four years. So the path constant should be removed and the files provided by Maps?

PeterTheOne mentioned this pull request

Add missing cluster marker images #142

Merged

kghbln closed this

kghbln deleted the issue138 branch

May 22, 2016 09:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet