Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added vulnerability scan PR check #475

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Added vulnerability scan PR check #475

merged 1 commit into from
Jun 28, 2024

Conversation

karan-batavia
Copy link
Contributor

No description provided.

khemrajrathore
khemrajrathore reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@khemrajrathore khemrajrathore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the testing done?

@karan-batavia
Copy link
Contributor Author

Is the testing done?

@khemrajrathore https://github.com/Privado-Inc/privado-core/actions/runs/9712327580 Link to a sample run on privado-core, same check we have here.

khemrajrathore
khemrajrathore approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@khemrajrathore khemrajrathore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karan-batavia karan-batavia merged commit d84a439 into dev Jun 28, 2024
10 checks passed
@karan-batavia karan-batavia deleted the vuln-scan branch June 28, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khemrajrathore khemrajrathore khemrajrathore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karan-batavia @khemrajrathore