Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move reference to Xamarin.Forms.Mocks to nuget/packageReference #2091

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Move reference to Xamarin.Forms.Mocks to nuget/packageReference #2091

merged 1 commit into from
Apr 23, 2020

Conversation

lv1il0s
Copy link
Contributor

@lv1il0s lv1il0s commented Apr 23, 2020 •
edited
Loading

Description of Change

Moved references to Xamarin.Forms.Mocks to nuget/packageReference. Solves #2057.

Deleted tests/Forms/Prism.DI.Forms.Tests/MockForms.cs file containing existing Xamarin.Forms.Mocks namespace and added nuget packages instead.

Bugs Fixed

None

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@lv1il0s lv1il0s requested a review from dansiegel as a code owner April 23, 2020 23:40
@dnfclas
Copy link

dnfclas commented Apr 23, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

dansiegel
dansiegel approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR

@dansiegel dansiegel merged commit 05c82a2 into PrismLibrary:master Apr 23, 2020
@lv1il0s
Copy link
Contributor Author

lv1il0s commented Apr 23, 2020

Thank you for guidance and quick responses!

@dansiegel dansiegel mentioned this pull request Apr 24, 2020
Closed
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lv1il0s @dnfclas @dansiegel