-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Qt base translation to our own #19
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Trial97 <[email protected]>
Could you test this locally? IIRC we support loading translations locally somehow, but I don't think we documented it anywhere |
@Scrumplex when I run the update on the master branch the files are modified(https://github.com/PrismLauncher/Translations/blob/master/update.sh) like in a bad way: e.g the template file becomes empty. |
I feel like the root issue here is Qt. We shouldn't really need to ship Qt's own translations. On my NixOS system, I also can't reproduce this issue in the first place. Perhaps something is wrong with the way we create our binary packages? |
Maybe but if we do add the qt to our translation the users will be able to translate the string for each language that we support and not be limited to qt ones |
Signed-off-by: Trial97 <[email protected]>
Signed-off-by: Trial97 <[email protected]>
Ok, I was able to test this locally, with the help of a docker image.
|
I don't know if this works as intended: it builds but locally the .template file is emptied regardless if I run with or without my change.
Regarding the Licence issues this was downloaded from the qt website(https://l10n-files.qt.io/l10n-files/) also the git repo licenses https://code.qt.io/cgit/qt/qttranslations.git/tree/LICENSES?h=6.5
Theoretically, we are not using any of the translations provided by them, just the template to add to our own.
this should fix PrismLauncher/PrismLauncher#2833 and any other translation issue with the qt in our code.