Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qt base translation to our own #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Sep 23, 2024

I don't know if this works as intended: it builds but locally the .template file is emptied regardless if I run with or without my change.
Regarding the Licence issues this was downloaded from the qt website(https://l10n-files.qt.io/l10n-files/) also the git repo licenses https://code.qt.io/cgit/qt/qttranslations.git/tree/LICENSES?h=6.5
Theoretically, we are not using any of the translations provided by them, just the template to add to our own.
this should fix PrismLauncher/PrismLauncher#2833 and any other translation issue with the qt in our code.

@Scrumplex
Copy link
Member

Could you test this locally? IIRC we support loading translations locally somehow, but I don't think we documented it anywhere

@Trial97
Copy link
Member Author

Trial97 commented Sep 23, 2024

@Scrumplex when I run the update on the master branch the files are modified(https://github.com/PrismLauncher/Translations/blob/master/update.sh) like in a bad way: e.g the template file becomes empty.
So sure I can generate the files but I have no way to determine if they are correct as even the unmodified version is broken somehow.

@Scrumplex
Copy link
Member

I feel like the root issue here is Qt. We shouldn't really need to ship Qt's own translations. On my NixOS system, I also can't reproduce this issue in the first place. Perhaps something is wrong with the way we create our binary packages?

@Trial97
Copy link
Member Author

Trial97 commented Sep 23, 2024

Maybe but if we do add the qt to our translation the users will be able to translate the string for each language that we support and not be limited to qt ones

@Trial97
Copy link
Member Author

Trial97 commented Sep 23, 2024

Ok, I was able to test this locally, with the help of a docker image.
Steps I did to determine that it works:

  • build a basic dockerfile based on the update workflow env
  • run that container by mounting the current repo inside
  • run the ./update.sh script
  • observe that there were only additions (I can post the result as a separate commit/branch if needed)
  • go to a language that you know
  • update all the close references and save
  • in the docker run the release.sh file
  • identify the qm file generated for the language
  • open the prism translation folder
  • replace the mmc_ file with the new translation (for me I had the translation already selected and prism closed at this step)
  • stop internet(so the translation to not update due to sha mismatch)
  • start prism
  • go to settings and observe that the close button for that dialog now has the string from the translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StandardButtons ignore selected language
2 participants