-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Αdding support for Q# language #2804
Conversation
JS File Size Changes (gzipped)A total of 3 files have changed, with a combined diff of +1.02 KB (+22.7%).
|
Thank you for the PR @fedonman! Right now, your Q# is still too C#-like (e.g. Q# doesn't have verbatim strings or multiline comments). There are also a few missing keywords and operators. Fortunately, Microsoft provides a full ANTRL4 grammar for Q#, so missing keywords and operators shouldn't be a problem. This grammar is extremely useful, so I recommend using it (it has the answer to literally all questions regarding Q# syntax). And please add more tests. Q# is a simple language compared to C# but it is not trivial, so please test keywords, operators, and the |
Thank you for the grammar link! It really helps. I have:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will be the last round.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last review round, I think.
Please take a look at my comments and resolve the merge conflicts.
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Thank you for contributing @fedonman! |
This is more like a stripped version of C# with some minor modifications to match Q# style. Code highlighting is pretty good so far, although some improvements are already identified (like special functions, and integration with C# / Python host programs)