-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Jexl #2764
Add support for Jexl #2764
Conversation
7860844
to
bbe679c
Compare
@RunDevelopment Before I resolve the conflicts, is this something you‘d be interested in? Thanks in advance! |
Conflicts are resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @czosel.
I looked at Jexl and your language definition and there are few things that need to be addressed (nothing major).
Also, please follow the quoting style we use. We use single quotes and token names are always quoted. See CSS as an example.
I want to ask about the current status of the Jexl project. There hasn't been any activity for half a year now which is kinda worrying.
Hi @RunDevelopment, thanks for the detailed review! I'll address the points you mention over the coming days. Regarding the status of the project: It's a small language (just expressions), I'd see the fact that nothing happened over the last 6 months as a sign of stability 😉 I'm not involved with the Jexl project myself, but my company is a heavy user of Jexl and would potentially be committed to help maintaining it, should the need ever arise. |
The lack of commits, yes. What worried me more was that nobody responds to new issues and PRs. But it's good to know that there are people willing to step in. |
8f00058
to
72a511b
Compare
Hi @RunDevelopment |
Please ignore the last review comment. The "It really isn't. I'm sorry, this is my bad. I assumed that .4 (as in JS) is a number. In that case, both the original and my suggested pattern are incorrect. I'll suggest a new one." one. GitHub has a bug with its review comment system and I triggered that bug... |
Jexl is the [Javascript Expression Language](https://github.com/TomFrost/Jexl).
@RunDevelopment Should we still change something about the numbers? |
I say we just leave it as is. |
Thank you for contributing @czosel! |
Awesome 🎉 Thanks for the detailed review, and your work on Prism in general! Do you already have a new release planned? :-) |
Thanks. I do want to make a new release soon-ish but not until a few of the more recent PRs get merged. |
Jexl is the Javascript Expression Language.