Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized templating logic implementation #2002

Closed
wants to merge 9 commits into from

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jul 26, 2019

This implements a standardized templating logic and resolves #1991.

The new "language" exposes two functions: createTemplate and tokenizeWithHooks.
While tokenizeWithHooks is just utility which is exposed for convenience, createTemplate is the heart of the PR.

Edit: It now also exposes a replaceWithTemplate function which is basically a generalization of Markup templating (MT). MT is just a thin wrapper around this templating library now.

@RunDevelopment
Copy link
Member Author

Can we merge this?

I can't implement #2403 with Markup Templating alone. In Balde templates, you can escape statements and directives by adding an @ symbol in front of it. To catch this, I need lookbehinds that I don't have in Markup Templating.
While impossible in the current Markup templating, it's trivial to do in the Markup templating of this PR.

@mAAdhaTTah @Golmote

@RunDevelopment
Copy link
Member Author

Closed in favor of #3541.

@RunDevelopment RunDevelopment deleted the templating branch August 31, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize templating logic
1 participant