Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sas improvements #1980

Closed
wants to merge 4 commits into from
Closed

Conversation

cedporter
Copy link
Contributor

Substantial improvements to language-sas syntax highlighting.

  • Added numerous language elements
  • Created more granular keyword objects, for finer grained styling if desired
  • Expanded keyword regex list
  • Special identification of PROC SQL and the SQL that follows
  • Test coverage for all added language elements

@cedporter cedporter closed this Jul 15, 2019
@RunDevelopment
Copy link
Member

@cedporter
Why did you close it? There are a lot of good things in here.

@cedporter
Copy link
Contributor Author

@RunDevelopment, just needed to clean up the commit history. It's resubmitted!

@RunDevelopment
Copy link
Member

You can just force push in this case, although you generally don't need to clean up your commit history. We (well, git(-hub) actually) will squash all of your commits into one before committing to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants