Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .scss files #1521

Closed
wants to merge 1 commit into from
Closed

Added .scss files #1521

wants to merge 1 commit into from

Conversation

TokugawaTakeshi
Copy link

Because of this issue, I offer you to add .scss versions of .css files. In the future, you can write your completely on SASS and .css files will be the output, however currently I just copied css files and changed extension.

@RunDevelopment
Copy link
Member

It'd be good to also have a proper workflow to compile the SCSS files if we were to add this to Prism.
Otherwise, these files just sit there, not doing anything.

The repo you mentioned links a gulp plugin for SASS, so maybe we could use it.
Thoughts?

@TokugawaTakeshi
Copy link
Author

TokugawaTakeshi commented Aug 11, 2018

It'd be good to also have a proper workflow to compile the SCSS files if we were to add this to Prism.

Of course. But maybe we need to reconsider the project file system for the logical separation source and destination folders.

Otherwise, these files just sit there, not doing anything.

Libraries often included in other files. Same for prismjs: .scss could be included in other .scss or .sass files, so at least sass warning that I mentioned will disappear.

The repo you mentioned links a gulp plugin for SASS, so maybe we could use it. Thoughts?

I think it will be very good decision for the future library development. Please let me know how you want to re-organize your project file system before adding gulp.

@mAAdhaTTah
Copy link
Member

If we're going to add scss, we should take advantage of what scss provides us. As @RunDevelopment mentioned, if we're just adding a bunch of new files that don't do anything, there's not a lot of value to adding them and it's an extra maintenance burden to keep them in sync.

I'm definitely interested in bringing sass in as tool, but I wouldn't do it piecemeal like this. We haven't settled on how we'd organize a project, but code talks; if you have an idea, we'd be interested in seeing it!

I'm going to close this PR, but feel free to open a new one if you have more fleshed out ideas!

@mAAdhaTTah mAAdhaTTah closed this Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants