JavaScript highlighting should be improved

[felixsanz]

JS highlighting fails too much, even at simple use cases. Example:

Most of it it's wrong. I wish i could provide a patch but i can just report it.

[Golmote]

Please provide the entirety of the code you're trying to highlight. It seems to me that the initial highlighting problem occurs before this snippet.

[felixsanz]

You're right. That single piece works better as standalone.

import cluster from 'cluster'
import os from 'os'

const workers = os.cpus().length

cluster.setupMaster({ exec: 'app.js' })

function log(msg) {
  console.log(`[SERVER] ${new Date().toISOString().replace(/T/, ' ').replace(/\..+/, '')} ${msg}`)
}

log(`Master with pid ${process.pid} starting...`)

for (let i = 0; i < workers; i++) {
  cluster.fork()
}

cluster.on('exit', (worker, code, signal) => {
  log(`worker with pid ${worker.process.pid} died. Restarting...`)
  cluster.fork()
})

cluster.on('online', worker => {
  log(`Worker with pid ${worker.process.pid} started`)
})

^ GitHub's syntax highlighter has no problems

[Golmote]

@LeaVerou @zeitgeist87 Does it look safe to you to move up the template string pattern in the language definition of JS so that it's processed before normal strings? IMO it is much more common to encounter quotes inside template strings than backticks inside normal strings. What do you think?

[LeaVerou]

Agreed.

[zeitgeist87]

If we move the template-string before string, then one of the tests for coffeescript fails, because coffeescript uses backticks for inline javascript. However this is easily fixed by adding the following line to the coffeescript language:

delete Prism.languages.coffeescript['template-string'];

Shall I commit my changes?

[LeaVerou]

Sounds good to me!

[Golmote]

Yup, agreed!

[zeitgeist87]

Should be fixed with [1158e46]

[felixsanz]

I was about to test this (even if it's already a closed issue...) to report the status and how that code renders now, but i don't know how to install this with npm since this versions are published into gh-pages branch (uh?), and that is not released into npm, right?

How i do install it then?

[zeitgeist87]

For a quick test you can use http://prismjs.com/test.html or check out the gh-pages branch manually. The fix will be published to npm with the next release, which should be soon.

[felixsanz]

this look much better now, thanks

[exander77]

It still seems to be broken for backticks, try this:

var a = [
    '`a',
    '`b'
];