Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom class: Change map API #2983

Closed
RunDevelopment opened this issue Jul 4, 2021 · 0 comments
Closed

Custom class: Change map API #2983

RunDevelopment opened this issue Jul 4, 2021 · 0 comments
Labels
enhancement plugins
Milestone
2.0

Comments

@RunDevelopment
Copy link
Member

Motivation
#2947 added a new apply API which is necessary for plugin compatibility. This API had to include a language parameter because it was required by the map API.

However, this language parameter doesn't really make sense. Mapping aliases should be language-independent especially considering embedded languages.

The language parameter is also a problem for plugin compatibility. Some plugins (e.g. File highlight, JSONP highlight) change the code and language of a code block. It's not possible for other plugins to determine the language before those plugins.

Description
Remove the language parameter from both the map and apply API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement plugins
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@RunDevelopment