migrate CI to github actions #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #677 +/- ##
============================================
- Coverage 98.00% 86.54% -11.47%
============================================
Files 226 12 -214
Lines 12352 446 -11906
Branches 66 66
============================================
- Hits 12106 386 -11720
+ Misses 246 60 -186 |
rlskoeser
force-pushed
the
thatbudakguy/issue634
branch
from
f7cc218
to
eeb8c16
Compare
rlskoeser
force-pushed
the
thatbudakguy/issue634
branch
from
22b8359
to
439a795
Compare
rlskoeser
force-pushed
the
thatbudakguy/issue634
branch
from
21cb923
to
0ef20ca
Compare
|
@thatbudakguy the build is working now, the python unit tests are just failing on a single test that's also failing in travis. Do you want to review my changes and see if you have any concerns before we merge? |
thatbudakguy
commented
Jan 20, 2021
Comment on lines
+91
to
+95
| # use docker cp to copy the configset, then bash to set ownership to solr | ||
| - name: Copy Solr configset to solr service | ||
| run: | | ||
| docker cp solr_conf ${{ job.services.solr.id }}:/opt/solr/server/solr/configsets/sandco | ||
| docker exec --user root ${{ job.services.solr.id }} /bin/bash -c "chown -R solr:solr /opt/solr/server/solr/configsets/sandco" |
There was a problem hiding this comment.
awesome that this worked; maybe we could extract it to a shell script at some point
package.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "start": "npm run dev", | |||
| "test": "npm run test:unit && npm run test:a11y", | |||
| "test:unit": "jest --collectCoverage", | |||
| "test:a11y": "pa11y-ci --sitemap http://localhost:8000/sitemap-pages.xml", | |||
| "test:a11y": "pa11y-ci --sitemap http://localhost:8000/sitemap.xml", | |||
There was a problem hiding this comment.
we should remove this because we don't have pa11y-ci anymore
lighthouserc.js
Outdated
| @@ -0,0 +1,30 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
might not need this file for this PR since we split off the a11y/lighthouse stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.python-versionfile as single source of truth for python version; remove matrixwheeltodev-requirements.txt