-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create_result
and update_order
#11
Conversation
f991d27
to
b3bc466
Compare
Check if manual edits here need to be carried over: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
So I followed the rabbit hole, and turns out that OpenAPI doesn't have a "good" way to handle redirect responses. The only suggestion I found was this one, which suggests indicating that the response has a response(302, 'found') do
header 'Location', schema: { type: :string }, description: 'The signed URL to download the report' which correctly adds the documentation like this IMPORTANT: header 'Location', type: :string, description: 'The signed URL to download the report' (without the responses:
'302':
description: found
headers:
location:
type: string
description: The signed URL to download the report instead of responses:
'302':
description: found
headers:
location:
- schema:
- type: string
+ type: string
description: The signed URL to download the report which is actually what the Swagger docs indicate it should be. That all said, even with these changes, the generated Interestingly enough, looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for handling the manual edits I made!
f889aae
to
db0c5de
Compare
- Added `create_result` - Added `update_order` - Included auto-generated models
db0c5de
to
5051fa5
Compare
scripts/generate_clients.sh
inconnect
has been replaced by individual rake tasks per language and the Ruby one has been made to consume a version number (e.g.rake connect_client:ruby[1.0.0]
) that gets piped into the generated client, as well as copying the updated files to the sibling folder containing the gem, ready for publishing.InlineResponse200X
classes which makes for a poor dev UX when using the client. Now the responses are more clearlyPrimaryConnectClient::Orders
,PrimaryConnectClient::OrderIds
, etc.update_order
and the previously undocumentedcreate_result
API endpoints