Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Embed meta tags load on removed posts #68

Closed
1 task done
superfever3000 opened this issue Jun 11, 2024 · 1 comment
Closed
1 task done

[Bug]: Embed meta tags load on removed posts #68

superfever3000 opened this issue Jun 11, 2024 · 1 comment
Assignees
@CaramelKat
Labels
approved The topic is approved by a developer bug Something isn't working

Comments

@superfever3000
Copy link

superfever3000 commented Jun 11, 2024 •
edited
Loading

Checked Existing

  • I have checked the repository for duplicate issues.

What happened?

When you remove a post on Juxtaposition, then visit it on the web, it says "Post has been removed"
However, if you take a look at the head in the HTML, it still contains embed metadata that embeds the post in other places.

What did you expect to happen?

I expect the embed meta tags to not be present, as the website clearly defines the post being removed.

Steps to reproduce?

Look at any deleted post, then look at the head in the HTML.
Optionally, attempt to send the link to a place like a Discord channel and watch it embed.
image
Screenshot was taken today, post was deleted a while ago

Other relevant information. (OPTIONAL)

No response
@superfever3000 superfever3000 added awaiting-approval Topic has not been approved or denied bug Something isn't working labels Jun 11, 2024
@jonbarrow jonbarrow added approved The topic is approved by a developer and removed awaiting-approval Topic has not been approved or denied labels Jun 21, 2024
CaramelKat added a commit that referenced this issue Jul 29, 2024
@CaramelKat
fix: hide meta tags from removed posts #68
60730f3
@CaramelKat CaramelKat self-assigned this Jul 29, 2024
@CaramelKat
Copy link
Member

Fixed in 60730f3. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaramelKat CaramelKat

Labels
approved The topic is approved by a developer bug Something isn't working
Projects
Pretendo Tasks and Goals
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonbarrow @CaramelKat @superfever3000