-
Notifications
You must be signed in to change notification settings - Fork 22
BO ps_reminder emails translations #20
base: dev
Are you sure you want to change the base?
Conversation
Could this PR be merged? |
This PR needs to be rebased (sorry for the delay) |
Hello @bm-services, thanks for your contribution, would you mind to rebase your pull request? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still the case with the recently introduced modern email template? |
Actually, I would even add more explicit information (make the name of the email match the configuration settings) while working on it: followup_1 would give canceled_cart in ps_reminder @Progi1984, could it introduce a breaking change? |
@PrestaShop/prestashop-core-developers Need your help for answering to @LouiseBonnard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in ps_reminder.php, the variable cron_url needs to be declared before it can be used
This variable is already declared: line 747 https://github.com/PrestaShop/ps_reminder/blob/4ab93e38e52a50d80f024a7f5dbc2e1867031319/ps_reminder.php |
Fixed issue #9585 - BOOM-5975