Fix Typo in phpMyAdmin example #1895
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the service is mysql not some-mysql
randallmorse
changed the title
SharakPL
requested changes
Dec 1, 2024
SharakPL
approved these changes
Dec 1, 2024
…the mysql service The network should be defined or the container wont be able to reach the mysql service unless you expose the ports. This is likely the best example.
with the PMA_HOST and PMA_PORT and PMA_ARGITRARY defined it seems that the intent is to have the system leverage this connection information, however with out the PMA_USER and the PMA_PASSWORD configuration set this information is not used, to better serve the example the db user and pass from lines 25 and 26 could be set here and then the container would auto login for phpMyAdmin for the example
randallmorse
commented
Dec 2, 2024
| environment: | ||
| PMA_HOST: some-mysql | ||
| PMA_PORT: 3306 | ||
| PMA_ARBITRARY: 1 | ||
| PMA_USER: root | ||
| PMA_PASSWORD: admin |
There was a problem hiding this comment.
@SharakPL is this the intent of having the host name and port set here? see comment on the commit, at current it isnt used unless the the PMA_HOST and PMA_PASSWORD is set, I think this might have been the intent and if not could be a great add to the example to assist new users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the service is mysql not some-mysql