Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery from Simulator Crashes #247

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Recovery from Simulator Crashes #247

wants to merge 20 commits into from

Conversation

Prerna-0202
Copy link
Owner

@Prerna-0202 Prerna-0202 commented Mar 19, 2023

GSOC

POC

Fixes #243

Describe the changes you have made in this PR -

Currently, we only have a feature of recovering projects after reloading or closing the tab, which is not working as expected.
I have fixed that recover project option and now projects can be recovered after reloading or closing the tab.

Workflow for recovering the project after reloading or closing the tab:-

  1. Try to reload the page, first, the alert came "Changes you made may not be saved".
  2. If the user still selects reload, then after reloading a message shown on the screen
  3. "We have detected that you did not save your last work. Don't worry we have recovered them. Access them using Project->Recover"
  4. Now, the user clicks on the recover project option and a confirm box came "Would you like to recover: ${data. name}?"
  5. If the user selects Ok, then the circuit recovers successfully.

Also, I Implemented a safe recovery from unexpected simulator crashes.
The safe recovery, lets the user restore a previous non-erroneous state of the circuit

Workflow for simulator crash recovery:-

  1. When the simulator crashes, Try to reload the page, first, the alert came "Changes you made may not be saved".
  2. Then the user has to select reload, then after reloading a message shown on the screen.
  3. "We have detected an unexpected simulator crash. Don't worry we have recovered your project. Access them using Project->Recover"
  4. Now, the user clicks on the recover project option and a confirm box came "Would you like to recover: ${data. name}?"
  5. If the user selects Ok, then the circuit with the previous non-erroneous state recovers successfully.

Screenshots of the changes (If any) -

Recovery of the project after simulator crash:-

simulator-crash-recoveryy_BAN8nVnr.webm

Recover Project after reloading:-

recover_project_solution.webm

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@Prerna-0202 Prerna-0202 marked this pull request as ready for review March 19, 2023 17:56
@Prerna-0202 Prerna-0202 changed the title Crash recovery Recovery from Simulator Crashes Mar 19, 2023
dependabot bot and others added 20 commits March 24, 2023 19:19
Bumps [rack](https://github.com/rack/rack) from 2.2.6.3 to 2.2.6.4.
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md)
- [Commits](rack/rack@v2.2.6.3...v2.2.6.4)

---
updated-dependencies:
- dependency-name: rack
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…cuitVerse#3680)

Bumps [activesupport](https://github.com/rails/rails) from 6.1.7.1 to 6.1.7.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v7.0.4.3/activesupport/CHANGELOG.md)
- [Commits](rails/rails@v6.1.7.1...v6.1.7.3)

---
updated-dependencies:
- dependency-name: activesupport
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(i18n): add marathi support i18n, add locale marathi for whole site
…s & fix the stylings (CircuitVerse#3627)

* feat(avtar): add avtar, add avtar in the group cards fix the stylings

Signed-off-by: Arnabdaz <[email protected]>

---------

Signed-off-by: Arnabdaz <[email protected]>
* feat: added notification for new group event

Signed-off-by: VaibhavUpreti <[email protected]>
Co-authored-by: Vedant Jain <[email protected]>
…rse#3557)

* fix(ui): fix non alinged dismissible alert texts

Signed-off-by: Arnabdaz <[email protected]>

* fix(ui): fix unalinged alert texts issue CircuitVerse#3556

---------

Signed-off-by: Arnabdaz <[email protected]>
…ircuitVerse#3559)

* fix(ui): comment text, fix multiline comments too much line spacing
…ircuitVerse#3585)

* fix(ui): check box, fix check-box tick to fit and correctly align in its container box

Signed-off-by: Arnabdaz <[email protected]>

* fix(ui): check box, fix check-box tick to fit and correctly align in its container box

Signed-off-by: Arnabdaz <[email protected]>

* fix(ui): check box,fix check-box tick to fit and correctly align in its container box

Signed-off-by: Arnabdaz <[email protected]>

* fix(ui): check box,fix check-box tick to fit and correctly align in its container box

Signed-off-by: Arnabdaz <[email protected]>

* fix(ui): check box,fix check-box tick to fit and correctly align in its container box

Signed-off-by: Arnabdaz <[email protected]>

* fix(ui): check box,fix check-box tick to fit and correctly align in its container box

Signed-off-by: Arnabdaz <[email protected]>

* fix(ui): check box, fix check-box tick to fit and correctly align in its container box

* fix check-box tick to fit and correctly align in its container box

---------

Signed-off-by: Arnabdaz <[email protected]>
…itVerse#3388)

* fix: style of the projectName so that it is visible completely
Bumps ruby from 3.2.0-slim to 3.2.1-slim.

---
updated-dependencies:
- dependency-name: ruby
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…erse#3694)

Bumps [@commitlint/cli](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/cli) from 17.0.2 to 17.5.0.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/cli/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v17.5.0/@commitlint/cli)

---
updated-dependencies:
- dependency-name: "@commitlint/cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: erb tags
* fix: ci ruby style
@@ -82,7 +82,7 @@
<% @alumni.each do |member| %>
<div class="team-member-container team-link">
<div class="team-underline">
<a target="_blank" href="<%= member[:link] %>"><%= image_tag member[:img], :class => "about-contributor-image " %><p class="team-footer underline"><%= member[:name] %></p></a>
<a target="_blank" href="<%= member[:link] %>"><%= image_tag member[:img], class: "about-contributor-image " %><p class="team-footer underline"><%= member[:name] %></p></a>

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
@@ -62,7 +62,7 @@
<% @mentors.each do |member| %>
<div class="team-member-container team-link">
<div class="team-underline">
<a target="_blank" href="<%= member[:link] %>"><%= image_tag member[:img], :class => "about-contributor-image" %><p class="team-footer"><%= member[:name] %></p></a>
<a target="_blank" href="<%= member[:link] %>"><%= image_tag member[:img], class: "about-contributor-image" %><p class="team-footer"><%= member[:name] %></p></a>

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
@@ -42,7 +42,7 @@
<% @cores.each do |member| %>
<div class="team-member-container team-link ">
<div class="team-underline">
<a target="_blank" href="<%= member[:link] %>"><%= image_tag member[:img], :class => "about-contributor-image" %><p class="team-footer "><%= member[:name] %></p></a>
<a target="_blank" href="<%= member[:link] %>"><%= image_tag member[:img], class: "about-contributor-image" %><p class="team-footer "><%= member[:name] %></p></a>

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a safe recovery from simulator crashes
6 participants