-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Enhancements to run page run-config inputs with new dict, json, yaml inputs #1095
Conversation
…supporting only string
…nging parent value
great find @zhen0, I was able to fix that without a significant refactor but it still might be worth running through your QA once more to validate that I didn't break something else? |
I've taken a look at this but want to do another pass with the changes requested by @zhen0 & @ThatGalNatalie - will submit a review this evening |
I just noticed this while looking at #1104 but the screen freezes for me when I switch from list to date with a value present freeze.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few notes wrt error states @stackoverfloweth:
- With validation on most of the dict-type input fields, focusing and bluring the inputs without any changes forces them into an error state
- Selecting an "Auto" type explicitly after typing in a key/value forces the component into an error state
- When part of the form is in an error state, the form shouldn't be submittable
Otherwise these changes look great!
…ered not intferred when created with value;
@znicholasbrown requested changes have been implemented, thanks for the suggestion! |
suggestions have been addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with local run, universal run and K8s run - all go through with no (or expected) issues. Switching types also no longer causes any problems.
I'd like to wait to merge this to staging until we do a release (tomorrow) so that we can demo etc before we release these changes to prod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (there are changelog conflicts but I think those will be resolved elsewhere 👍🏻 )
PR Checklist:
CHANGELOG.md
Describe this PR
Built new "code input" components to replace DictInput, JsonInput, and YamlInput. Also created ResettableWrapper, broke out separate forms for each run config type, and other minor code/ux improvements