Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Run Config overrides Kubernetes imagePullSecrets #1066

Closed
5 tasks
zhen0 opened this issue Sep 28, 2021 · 0 comments · Fixed by #1095
Closed
5 tasks

BUG: Run Config overrides Kubernetes imagePullSecrets #1066

zhen0 opened this issue Sep 28, 2021 · 0 comments · Fixed by #1095
Assignees
Labels
bug Something isn't working Run Page Related to the UI Run Page
Milestone

Comments

@zhen0
Copy link
Member

zhen0 commented Sep 28, 2021

Bug Description

Context: for our k8s agents we have image pull secrets defined for the cluster so that flows don't need to provide their own in order to be able to pull images from the container registry. i.e. the job templates we provide to KubernetesRun config don't contain imagePullSecrets.
Problem: when submitting a job from UI with the Run button, if we don't touch the AdvancedConfiguration section, the configuration that gets passed to k8s has (eg flow run)
"image_pull_secrets": null,
But if the user opens the AdvancedConfiguration tab and than hits Run the configuration passed to k8s has (eg flow run)
"image_pull_secrets": []
This happens even if nothing is changed in AdvancedConfiguration. I.e. the sole action of opening the tab before hitting run results in this change. The result is disastrous because the null value does not override the cluster image pull secret default but the empty list does override it resulting in the pod being unable to pull the image.
Desired behavior: opening the AdvancedConfiguration and changing any of the settings should not produce a change in the image_pull_secrets settings (or any other setting for that matter that the user did not change)

Steps To Reproduce

Browsers Tested:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Notes

@zhen0 zhen0 added bug Something isn't working Run Page Related to the UI Run Page labels Sep 28, 2021
@stackoverfloweth stackoverfloweth linked a pull request Oct 7, 2021 that will close this issue
2 tasks
@zhen0 zhen0 added this to the Run Page milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Run Page Related to the UI Run Page
Projects
None yet
2 participants