Add a copy method to task run result locations #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhen0
reviewed
Sep 2, 2021
src/pages/TaskRun/Details-Tile.vue
Outdated
| " | ||
| v-on="on" | ||
| > | ||
| <v-icon x-small class="mb-2px mr-2" tabindex="0"> |
There was a problem hiding this comment.
Should we add a v-if here to check if there's actually a result location to copy?
There was a problem hiding this comment.
Yeah that's sensible - the copy method won't throw an error since it checks for text to copy but I like hiding the icon in the case as well.
zhen0
reviewed
Sep 2, 2021
|
Updated 👍🏻 |
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.mdDescribe this PR
Adds a copy function to task run result locations.
Resolves: #969