-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a copy method to task run result locations #1033
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6649881
Add a copy method to task run result locations
znicholasbrown 75e2bb5
Update changelog
znicholasbrown 872963d
Merge branch 'master' into result-location-copy
znicholasbrown 4c86e39
Merge branch 'master' into result-location-copy
znicholasbrown 99e09dd
Merge branch 'master' into result-location-copy
znicholasbrown a87b3a7
Merge branch 'master' into result-location-copy
znicholasbrown 467d76c
Merge branch 'master' into result-location-copy
znicholasbrown 0106221
Merge branch 'master' into result-location-copy
znicholasbrown 4e4828f
Merge branch 'master' into result-location-copy
znicholasbrown b143ba2
Merge branch 'master' into result-location-copy
znicholasbrown 9035db3
Add v-if to copy text icon
znicholasbrown 2bbde2e
Merge branch 'master' into result-location-copy
znicholasbrown 29154c3
Merge branch 'master' into result-location-copy
znicholasbrown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a v-if here to check if there's actually a result location to copy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's sensible - the copy method won't throw an error since it checks for text to copy but I like hiding the icon in the case as well.