Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle set schedule active intelligently #37

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Aug 12, 2020

Thanks for contributing to Prefect Server!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • adds a changelog entry to the changes/ directory (if appropriate)

Note that your PR will not be reviewed unless these two boxes are checked.

What does this PR change?

This PR sets a Flow's schedule to inactive if neither it nor its Flow Group have a schedule. Not a bug, but the UI would display an active schedule with a warning message anytime I registered a Flow with no schedule and that was bothering me.

Why is this PR important?

Better match expectations. cc: @zhen0

@cicdw cicdw requested a review from jlowin as a code owner August 12, 2020 01:19
@github-actions github-actions bot added the API label Aug 12, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #37 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

@jlowin jlowin merged commit 055fed9 into master Aug 12, 2020
@jlowin jlowin deleted the toggle-set-schedule-active-intelligently branch August 12, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants