Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handling a keepalive value to apollo #293

Merged
merged 5 commits into from
Oct 1, 2021
Merged

Conversation

joe1981al
Copy link
Contributor

@joe1981al joe1981al commented Sep 21, 2021

Summary

Adding support for setting keep alive timeout of apollo service

Importance

Default keep alive setting causes issue with AWS ELB. See linked blog post for details.

Dealing with Intermittent 502's between an AWS ALB and Express Web Server

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)

@joe1981al joe1981al marked this pull request as ready for review September 21, 2021 23:43
Copy link
Contributor

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanieb zanieb merged commit f112f28 into PrefectHQ:master Oct 1, 2021
@zanieb zanieb mentioned this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants