submitted state lock #291
Merged
submitted state lock #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Sep 21, 2021
cicdw
reviewed
Sep 22, 2021
There was a problem hiding this comment.
@jakekaplan this LGTM but would you also mind adding a test at the GraphQL layer within tests/graphql/test_states.py that replicates the API level test at a higher level ?
|
@cicdw added the graphql test 👍 |
cicdw
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an in memory in process submitted state lock. Closes #203
Importance
Currently it is possible for multiple agents to pick up the same scheduled flow_run, this enables a buffer so that if multiple agents try to run the same flow_run only one will succeed.
Checklist
This PR:
changes/directory (if appropriate)