Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Track flow run id when generating task run results #8674

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

znicholasbrown
Copy link
Contributor

This PR improve task run-level results tracking by adding the task runs parent flow run id to the orchestration artifact.

Also adds a bit of test coverage for result <> run tracking since I couldn't find that anywhere.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@znicholasbrown znicholasbrown added the enhancement An improvement of an existing feature label Feb 28, 2023
@znicholasbrown znicholasbrown requested a review from a team as a code owner February 28, 2023 17:41
@netlify
Copy link

netlify bot commented Feb 28, 2023

Deploy Preview for prefect-docs ready!

Name Link
🔨 Latest commit db9e9f1
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs/deploys/63fe4535fe41c3000882b71f
😎 Deploy Preview https://deploy-preview-8674--prefect-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@znicholasbrown znicholasbrown merged commit 54d49a3 into main Feb 28, 2023
@znicholasbrown znicholasbrown deleted the enhancement-result-tracking-2023-02-28 branch February 28, 2023 18:41
ddelange added a commit to ddelange/prefect that referenced this pull request Mar 1, 2023
…aceful-agent

* 'patch-1' of https://github.com/ddelange/prefect: (25 commits)
  Enhancement: Track flow run id when generating task run results (PrefectHQ#8674)
  Fix loading of existing deployment descriptions from the server (PrefectHQ#8675)
  Update Dask logo (PrefectHQ#8669)
  Update `send_call` to `send_call_to_supervisor` (PrefectHQ#8653)
  Add Netlify Edge function to proxy to Segment (PrefectHQ#8657)
  Add security headers for docs (PrefectHQ#8655)
  Override analytics block instead of partial (PrefectHQ#8656)
  Add description flag to prefect deployment build CLI command (PrefectHQ#8603)
  Add support for yaml config strings to `KubernetesClusterConfig` (PrefectHQ#8643)
  Change lazy loads from joined to selectin (PrefectHQ#8659)
  Add timeout support to supervisors (PrefectHQ#8649)
  Minor markdown link fix in orchestration docs (PrefectHQ#8660)
  Allow more ports
  Bump @playwright/test from 1.30.0 to 1.31.1 in /ui (PrefectHQ#8663)
  Bump @prefecthq/prefect-ui-library from 1.1.9 to 1.1.10 in /ui (PrefectHQ#8661)
  Bump vite from 4.1.2 to 4.1.4 in /ui (PrefectHQ#8662)
  Bump eslint from 8.34.0 to 8.35.0 in /ui (PrefectHQ#8664)
  Fix of a typo - removed repeated word (PrefectHQ#8654)
  Enable DefaultAzureCredential authentication for Azure filesystem block (PrefectHQ#7513)
  Improve supervisor repr for debugging (PrefectHQ#8633)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants