Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseRSSFeed Task #856

Merged
merged 10 commits into from
Mar 26, 2019
Merged

ParseRSSFeed Task #856

merged 10 commits into from
Mar 26, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Mar 26, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

What does this PR change?

Adds a ParseRSSFeed task for parsing an RSS feed from a remote URL
Closes #853

Why is this PR important?

It is a common task and one I wanted personally :)

@joshmeek joshmeek added the integrations Related to integrations with other services label Mar 26, 2019
@joshmeek joshmeek requested review from cicdw and jlowin as code owners March 26, 2019 19:27
cicdw
cicdw previously approved these changes Mar 26, 2019
@cicdw
Copy link
Member

cicdw commented Mar 26, 2019

@joshmeek you need to add a pytest.importorskip statement to the __init__.py of your rss/ tests subdirectory. I love that test-vanilla-prefect job haha

tests/tasks/rss/__init__.py Outdated Show resolved Hide resolved
Co-Authored-By: joshmeek <[email protected]>
@cicdw cicdw merged commit 7b67035 into master Mar 26, 2019
@cicdw cicdw deleted the rss branch March 26, 2019 20:17
zanieb pushed a commit that referenced this pull request Jan 19, 2022
Fix an issue with an incorrect casing on utils import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Related to integrations with other services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants