-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hasura image version to 2.1.1 to fix M1 support #5335
Conversation
Proper Apple Silicon support was added to hasura/graphql engine in [v2.1.0](https://github.com/hasura/graphql-engine/releases/tag/v2.1.0) which should mean the prefect server can start up on M1 Macs without them needing [8GB of RAM](hasura/graphql-engine#6337 (comment))! I've tested this locally and everything seems to work great, with ~4 GB of RAM allocated to the Docker VM. Not sure if there are other integration tests I need to run for this, contributing docs only mentioned
Here I am, brain the size of a planet and they ask me to welcome you to Prefect. So, welcome to the community @treuherz! 🎉 🎉 |
Possibly the advice in the docs can be removed now as well, but I don't know if there are other circumstances it helps with than just the M1 crash. |
Hey @treuherz! Thanks for contributing. Would you mind opening a PR to the |
Hadn't caught the repo separation before. Done! |
I've fixed the problem with CircleCI (and submitted a docs fix for the problem) but I don't know how to retrigger the check! |
@treuherz I retriggered the check but the PrefectHQ/server#337 LGTM so I'll merge this after tests pass here. Thanks again! |
Whoops, thank you! |
* Bump hasura image version to fix M1 support Proper Apple Silicon support was added to hasura/graphql engine in [v2.1.0](https://github.com/hasura/graphql-engine/releases/tag/v2.1.0) which should mean the prefect server can start up on M1 Macs without them needing [8GB of RAM](hasura/graphql-engine#6337 (comment))! I've tested this locally and everything seems to work great, with ~4 GB of RAM allocated to the Docker VM. Not sure if there are other integration tests I need to run for this, contributing docs only mentioned * Add changes file * Fix changelog entry Co-authored-by: Michael Adkins <[email protected]>
Summary
Proper Apple Silicon support was added to
hasura/graphql
engine in v2.1.0. This brings it into the Server.Changes
Just the version of the
hasura/graphql
image in the server's composefile from 2.0.9 to 2.1.1Importance
This should mean the prefect server can start up on M1 Macs without them needing 8GB of RAM!
Checklist
This PR:
adds new tests (if appropriate)changes/
directory (if appropriate)updates docstrings for any new functions or function arguments, includingdocs/outline.toml
for API reference docs (if appropriate)