Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hasura image version to 2.1.1 to fix M1 support #5335

Merged
merged 4 commits into from
Jan 22, 2022
Merged

Bump hasura image version to 2.1.1 to fix M1 support #5335

merged 4 commits into from
Jan 22, 2022

Conversation

treuherz
Copy link

@treuherz treuherz commented Jan 19, 2022

Summary

Proper Apple Silicon support was added to hasura/graphql engine in v2.1.0. This brings it into the Server.

Changes

Just the version of the hasura/graphql image in the server's composefile from 2.0.9 to 2.1.1

Importance

This should mean the prefect server can start up on M1 Macs without them needing 8GB of RAM!

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Proper Apple Silicon support was added to hasura/graphql engine in [v2.1.0](https://github.com/hasura/graphql-engine/releases/tag/v2.1.0) which should mean the prefect server can start up on M1 Macs without them needing [8GB of RAM](hasura/graphql-engine#6337 (comment))!

I've tested this locally and everything seems to work great, with ~4 GB of RAM allocated to the Docker VM. Not sure if there are other integration tests I need to run for this, contributing docs only mentioned
@treuherz treuherz requested a review from zanieb as a code owner January 19, 2022 15:31
@marvin-robot
Copy link
Member

Here I am, brain the size of a planet and they ask me to welcome you to Prefect.

So, welcome to the community @treuherz! 🎉 🎉

@treuherz
Copy link
Author

Possibly the advice in the docs can be removed now as well, but I don't know if there are other circumstances it helps with than just the M1 crash.

@zanieb
Copy link
Contributor

zanieb commented Jan 19, 2022

Hey @treuherz! Thanks for contributing. Would you mind opening a PR to the prefecthq/server repository as well? That way we can make sure Server specific tests pass first.

@treuherz
Copy link
Author

Hadn't caught the repo separation before. Done!

@treuherz
Copy link
Author

I've fixed the problem with CircleCI (and submitted a docs fix for the problem) but I don't know how to retrigger the check!

@zanieb
Copy link
Contributor

zanieb commented Jan 21, 2022

@treuherz I retriggered the check but the - was missing :)

PrefectHQ/server#337 LGTM so I'll merge this after tests pass here.

Thanks again!

@zanieb zanieb merged commit fad6175 into PrefectHQ:master Jan 22, 2022
@treuherz
Copy link
Author

Whoops, thank you!

@zanieb zanieb mentioned this pull request Jan 25, 2022
lance0805 pushed a commit to hyl2015/prefect that referenced this pull request Aug 2, 2022
* Bump hasura image version to fix M1 support

Proper Apple Silicon support was added to hasura/graphql engine in [v2.1.0](https://github.com/hasura/graphql-engine/releases/tag/v2.1.0) which should mean the prefect server can start up on M1 Macs without them needing [8GB of RAM](hasura/graphql-engine#6337 (comment))!

I've tested this locally and everything seems to work great, with ~4 GB of RAM allocated to the Docker VM. Not sure if there are other integration tests I need to run for this, contributing docs only mentioned

* Add changes file

* Fix changelog entry

Co-authored-by: Michael Adkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants