Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adds prefect theming to storybook #16482

Merged
merged 1 commit into from
Dec 24, 2024
Merged

[UI v2] feat: Adds prefect theming to storybook #16482

merged 1 commit into from
Dec 24, 2024

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Dec 23, 2024 •
edited
Loading

https://storybook.js.org/docs/configure/user-interface/theming

  1. Adds prefect favicon to storybook
  2. Adds prefect logo to storybook

Screenshot 2024-12-23 at 9 31 04 AM

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Dec 23, 2024
@devinvillarosa devinvillarosa force-pushed the fun-ui-v2-storybook branch 2 times, most recently from 3f1da23 to f55a11a Compare December 23, 2024 17:38
@devinvillarosa devinvillarosa marked this pull request as ready for review December 23, 2024 17:42
desertaxle
desertaxle approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun!

@devinvillarosa devinvillarosa merged commit cbe7dd4 into main Dec 24, 2024
13 checks passed
@devinvillarosa devinvillarosa deleted the fun-ui-v2-storybook branch December 24, 2024 16:11
devinvillarosa added a commit that referenced this pull request Dec 24, 2024
@devinvillarosa
[UI v2] feat: Adds prefect theming to storybook (#16482)
c0da39c
devinvillarosa added a commit that referenced this pull request Dec 24, 2024
@devinvillarosa
[UI v2] feat: Adds prefect theming to storybook (#16482)
cfc63c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @desertaxle