cast None -> {} in KeyValueLabels
#16067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
commented
Nov 20, 2024
Comment on lines
-1191
to
-1211
| class BlockSchema(ObjectBaseModel): | ||
| """An ORM representation of a block schema.""" | ||
|
|
||
| checksum: str = Field(default=..., description="The block schema's unique checksum") | ||
| fields: Dict[str, Any] = Field( | ||
| default_factory=dict, description="The block schema's field schema" | ||
| ) | ||
| block_type_id: Optional[UUID] = Field(default=..., description="A block type ID") | ||
| block_type: Optional[BlockType] = Field( | ||
| default=None, description="The associated block type" | ||
| ) | ||
| capabilities: List[str] = Field( | ||
| default_factory=list, | ||
| description="A list of Block capabilities", | ||
| ) | ||
| version: str = Field( | ||
| default=DEFAULT_BLOCK_SCHEMA_VERSION, | ||
| description="Human readable identifier for the block schema", | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
unrelated tidyness: this was duplicated from L975 (it was an exact duplicate)
CodSpeed Performance ReportMerging #16067 will not alter performanceComparing Summary
|
bunchesofdonald
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Thanks Nate!
I also have this labels PR I've been working up (#16050) that uses a similar pattern. Feel free to merge this one and I'll deal with the conflicts on my side.
Co-authored-by: Chris Pickett <[email protected]>
desertaxle
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16066
should mitigate the immediate problem of validation errors but its not yet clear to me why
labels=Noneis passedand also moves the type to
prefect.types