Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new action to OpsGenieWebhook for apprise==1.9.0 compatibility #16030

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

kevingrismore
Copy link
Contributor

@kevingrismore kevingrismore commented Nov 15, 2024

apprise's new default MAP action for OpsGenie is a no-op (no notification is sent). To create an OpsGenie alert we need to include the new action type. As is, this is backwards compatible with older apprise versions, but if we bumped the minimum requirement for apprise to 1.9.0 we could either import and use OpsgenieAlertAction.NEW or maybe even support action as a block field instead of just sending a string.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@kevingrismore kevingrismore changed the title Add new action to OpsGenieNotification for apprise==1.9.0 compatibility Add new action to OpsGenieWebhook for apprise==1.9.0 compatibility Nov 15, 2024
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #16030 will not alter performance

Comparing opsgenie-action (b16a425) with main (a98b938)

Summary

✅ 3 untouched benchmarks

@kevingrismore kevingrismore marked this pull request as ready for review November 15, 2024 20:26
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevingrismore kevingrismore merged commit a8ac0e5 into main Nov 18, 2024
37 checks passed
@kevingrismore kevingrismore deleted the opsgenie-action branch November 18, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants