Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental worker logs setting #16024

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

abrookins
Copy link
Collaborator

@abrookins abrookins commented Nov 15, 2024

Worker logs are no longer experimental, so this PR removes references to the setting. We still want to avoid sending worker logs to open-source API servers until they support worker logs, though, so we use the existence of a backend_id on worker logs as a proxy for whether or not the worker is connected to Cloud. (Only workers connected to Cloud emit logs with worker IDs attached.)

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Worker logs are no longer experimental, so remove references to the
setting. We still want to avoid sending worker logs to open- source API
servers until they support worker logs, though, so we use the existing
of a `backend_id` on worker logs as a proxy for whether or not the
worker is connected to Cloud. (Only workers connected to Cloud emit logs
with worker IDs attached.)
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #16024 will not alter performance

Comparing remove-worker-logging-experiment (a3aa176) with main (377505b)

Summary

✅ 3 untouched benchmarks

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@abrookins abrookins merged commit 8dd8f3c into main Nov 15, 2024
39 checks passed
@abrookins abrookins deleted the remove-worker-logging-experiment branch November 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants