[UI v2] Fix tab order in variable create dialog #16014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
requested review from
aaazzam,
cicdw and
zzstoatzz
as code owners
desertaxle
changed the title
|
:chefs-kiss: |
aaazzam
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aaazzam discovered that the tab order was messed up on the
AddVariableDialogcomponent. I tracked the issue down to theCodeMirrorcomponent, but I don't know why it messed it up.Fortunately,
@uiw/react-codemirrorhas auseCodeMirrorhook that gives us more control over component creation. I useduseCodeMirrorto create aJsonInputcomponent that doesn't have the same tab order foibles.AddVarialbeDialogis now an upstanding citizen:Related to #15512