-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle UNC paths for windows #16005
handle UNC paths for windows #16005
Conversation
CodSpeed Performance ReportMerging #16005 will not alter performanceComparing Summary
|
fcc7238
to
82ab0e6
Compare
actually try again
82ab0e6
to
059f80c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me; I'm cool with the new job too given the filters you applied - I really like that approach
@zzstoatzz sorry just thinking through the workflow filters again -- do you think we benefit if it runs on core dependency changes ( |
to be safe I think that'd make sense, considering its not an expensive CI job. added in 591c3b5 |
closes #15971
I'm happy to remove this new CI job I used to repro, but it wont run unless we change the filesystem utils anyways