Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure workers emit stop events #16002

Merged
merged 1 commit into from
Nov 13, 2024
Merged

make sure workers emit stop events #16002

merged 1 commit into from
Nov 13, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Nov 13, 2024 •
edited
Loading

closes #15999

zzstoatzz
zzstoatzz commented Nov 13, 2024
View reviewed changes
src/prefect/events/filters.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are to make phantom "missing constructor kwargs" warnings go away

@github-actions github-actions bot added the bug Something isn't working label Nov 13, 2024
@zzstoatzz zzstoatzz added the fix A fix for a bug in an existing feature label Nov 13, 2024
@zzstoatzz zzstoatzz self-assigned this Nov 13, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #16002 will not alter performance

Comparing worker-stop-event (14a1643) with main (fc6eff4)

Summary

✅ 3 untouched benchmarks

@zzstoatzz zzstoatzz marked this pull request as ready for review November 13, 2024 18:25
desertaxle
desertaxle approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zzstoatzz zzstoatzz merged commit b4b5cae into main Nov 13, 2024
46 checks passed
@zzstoatzz zzstoatzz deleted the worker-stop-event branch November 13, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

Assignees

@zzstoatzz zzstoatzz

Labels
bug Something isn't working fix A fix for a bug in an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Worker does not emit stopped event
2 participants
@zzstoatzz @desertaxle