Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakes from pytest-xdist==3.5.0 #11231

Closed
1 task done
desertaxle opened this issue Nov 22, 2023 · 0 comments
Closed
1 task done

Fix flakes from pytest-xdist==3.5.0 #11231

desertaxle opened this issue Nov 22, 2023 · 0 comments
Labels
development Tech debt, refactors, CI, tests, and other related work.

Comments

@desertaxle
Copy link
Member

First check

  • I am a contributor to the Prefect codebase

Description

pytest-xdist 3.5.0 changed how scopes are scheduled: pytest-dev/pytest-xdist#778. This causes flakes on some of our tests which we'll need to fix to use pyest-xdist<=3.5.0. See https://github.com/PrefectHQ/prefect/actions/runs/6960547703 for an example.

Impact

No response

Additional context

No response
@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Nov 22, 2023
@desertaxle desertaxle mentioned this issue Nov 22, 2023
Merged
4 tasks
@chrisguidry chrisguidry self-assigned this Feb 5, 2024
chrisguidry added a commit that referenced this issue Feb 5, 2024
@chrisguidry
Bumping pytest-xdist to >= 3.5
eb34229 
Fixes #11231
@chrisguidry chrisguidry mentioned this issue Feb 5, 2024
Closed
@chrisguidry chrisguidry removed their assignment Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bumping pytest-xdist to >= 3.5 PrefectHQ/prefect
2 participants
@chrisguidry @desertaxle