Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update empirical policy #2740

Conversation

znicholasbrown
Copy link
Contributor

Deprecates max_retries and retry_delay_seconds fields, adds retry_jitter_factor field.

@znicholasbrown znicholasbrown requested a review from a team as a code owner September 18, 2024 15:43
@@ -60,16 +60,9 @@

<p-key-value label="Version" :value="taskRun.taskVersion" :alternate="alternate" />

<div v-if="taskRun.empiricalPolicy?.maxRetries">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field has been deprecated in Core for ~2 years so I think we're safe to stop displaying it.

@znicholasbrown znicholasbrown merged commit 8fc1e3a into main Sep 18, 2024
2 checks passed
@znicholasbrown znicholasbrown deleted the nicholas/chore/update-deprecated-empirical-policy-fields-2024-09-18 branch September 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants