Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: update button text from "delete" to "remove" to match the rest of the modal #226

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Feature: update button text from "delete" to "remove" to match the rest of the modal #226

merged 2 commits into from
Jun 15, 2022

Conversation

stackoverfloweth
Copy link
Contributor

Screen Shot 2022-06-15 at 12 26 54 PM

@stackoverfloweth stackoverfloweth requested a review from pleek91 June 15, 2022 17:27
@stackoverfloweth stackoverfloweth self-assigned this Jun 15, 2022
@netlify
Copy link

netlify bot commented Jun 15, 2022 •
edited
Loading

✅ Deploy Preview for orion-design ready!

Name Link
🔨 Latest commit 1b85938
🔍 Latest deploy log https://app.netlify.com/sites/orion-design/deploys/62aa20d07774150008eac309
😎 Deploy Preview https://deploy-preview-226--orion-design.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stackoverfloweth
Copy link
Contributor Author

prereq for https://github.com/PrefectHQ/nebula-ui/issues/815

pleek91
pleek91 reviewed Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct. This modal is usually triggered from a menu item that's labeled delete.

Remove also doesn't convey the action being taken as well IMO.

I'd rather see the rest of the modal say delete than change the button to say remove.

@stackoverfloweth
Copy link
Contributor Author

@pleek91 thoughts on that last commit?

@pleek91
Copy link
Collaborator

pleek91 commented Jun 15, 2022

@pleek91 thoughts on that last commit?

I like that 👍

@stackoverfloweth stackoverfloweth merged commit ef22e7c into main Jun 15, 2022
@stackoverfloweth stackoverfloweth deleted the remove-modal-button-change branch June 15, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleek91 pleek91 pleek91 approved these changes

Assignees

@stackoverfloweth stackoverfloweth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stackoverfloweth @pleek91