Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

adds pod tasks #21

Merged
merged 16 commits into from
Nov 16, 2022
Merged

adds pod tasks #21

merged 16 commits into from
Nov 16, 2022

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Nov 11, 2022 •
edited
Loading

Summary

Adds the pod tasks present in v1 Kubernetes Task Library, consolidates the client generation methods on KubernetesCredentials into a single get_client method and adds tests.

Relevant Issue(s)

Closes #17

Checklist

@zzstoatzz zzstoatzz added this to the v0.1.0 milestone Nov 11, 2022
@zzstoatzz zzstoatzz self-assigned this Nov 11, 2022
@zzstoatzz zzstoatzz changed the title addspod tasks adds pod tasks Nov 11, 2022
@zzstoatzz zzstoatzz marked this pull request as ready for review November 11, 2022 04:08
@zzstoatzz zzstoatzz requested a review from a team November 11, 2022 04:08
@zzstoatzz zzstoatzz linked an issue Nov 11, 2022 that may be closed by this pull request
add pod tasks #17
Closed
desertaxle
desertaxle suggested changes Nov 11, 2022
View reviewed changes
prefect_kubernetes/credentials.py Outdated Show resolved Hide resolved
prefect_kubernetes/pods.py Outdated Show resolved Hide resolved
prefect_kubernetes/pods.py Outdated Show resolved Hide resolved
prefect_kubernetes/pods.py Outdated Show resolved Hide resolved
prefect_kubernetes/pods.py Outdated Show resolved Hide resolved
prefect_kubernetes/pods.py Outdated Show resolved Hide resolved
prefect_kubernetes/pods.py Outdated Show resolved Hide resolved
prefect_kubernetes/pods.py Outdated Show resolved Hide resolved
tests/test_credentials.py Outdated Show resolved Hide resolved
tests/test_pods.py Outdated Show resolved Hide resolved
ahuang11
ahuang11 reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@ahuang11 ahuang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Also, if we change body here, I think we should also change body in the jobs module as well.

prefect_kubernetes/credentials.py Show resolved Hide resolved
prefect_kubernetes/pods.py Outdated Show resolved Hide resolved
ahuang11
ahuang11 reviewed Nov 15, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
prefect_kubernetes/jobs.py Show resolved Hide resolved
@desertaxle desertaxle self-requested a review November 16, 2022 16:00
desertaxle
desertaxle reviewed Nov 16, 2022
View reviewed changes
prefect_kubernetes/jobs.py Show resolved Hide resolved
prefect_kubernetes/jobs.py Show resolved Hide resolved
@zzstoatzz zzstoatzz requested a review from desertaxle November 16, 2022 18:09
desertaxle
desertaxle approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zzstoatzz zzstoatzz merged commit 7d32458 into main Nov 16, 2022
@zzstoatzz zzstoatzz deleted the pod-tasks branch November 16, 2022 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ahuang11 ahuang11 ahuang11 left review comments

@desertaxle desertaxle desertaxle approved these changes

Assignees

@zzstoatzz zzstoatzz

Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

add pod tasks
3 participants
@zzstoatzz @desertaxle @ahuang11