Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix logic to keep ACI deployment name within Azure character limit error #147

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix logic to keep ACI deployment name within Azure character limit error #147

merged 1 commit into from
Mar 19, 2024

Conversation

zzstoatzz
Copy link
Contributor

@zzstoatzz zzstoatzz commented Mar 19, 2024 •
edited
Loading

closes #146

we previously attempted to get the len of a UUID without first casting to a str

@zzstoatzz zzstoatzz requested a review from a team as a code owner March 19, 2024 18:48
@zzstoatzz zzstoatzz self-assigned this Mar 19, 2024
@zzstoatzz zzstoatzz added the fix label Mar 19, 2024
@zzstoatzz zzstoatzz changed the title cast uuid -> str before len Fix logic to keep ACI deployment name within Azure character limit error Mar 19, 2024
@desertaxle desertaxle merged commit 5e9ef2c into main Mar 19, 2024
4 checks passed
@desertaxle desertaxle deleted the fix-uuid-len branch March 19, 2024 19:29
@zzstoatzz zzstoatzz mentioned this pull request Mar 19, 2024
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desertaxle desertaxle desertaxle approved these changes

Assignees

@zzstoatzz zzstoatzz

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logic to keep ACI deployment name within Azure character limit error
2 participants
@zzstoatzz @desertaxle