Security: Update vue cli related packages #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the netlify deploy is broken by a python version mismatch separate from this PR. I'll check in separately. |
zhen0
requested review from
znicholasbrown and
stackoverfloweth
as code owners
zhen0
commented
Sep 9, 2022
| @@ -14,7 +14,7 @@ module.exports = { | |||
| 'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'off', | |||
| 'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off', | |||
| 'prettier/prettier': [ | |||
| 'error', | |||
| 'warn', | |||
There was a problem hiding this comment.
The update in the vue-cli created a bunch of prettier errors that broke our build. This switches them to 'warn' so that we can still build the ui and add the update.
stackoverfloweth
approved these changes
Sep 9, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<! -- What is it meant to do? -->
Updates Vue CLI, moment.js and nth-check versions
Linked Issues
<! -- Use a key word (e.g. closes or resolves) to close related issues -->
Tests and performance
Releases/Changelog cuts only