-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove requirement to add an API Secret for Pager Duty #1065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks @ThatGalNatalie
This isn't actually from your PR but in line https://github.com/PrefectHQ/ui/pull/1065/files#diff-3af46aeb97e3ab5dfecf9ff91442aa60a6bfd556c5f1b40ea61a760ffdfc3334R178
Could we add a check for apiToken?
E.g.
const whoTo = this.actionConfigArray.length
? this.actionConfigArray
: this.secretName || this.webhookURLString || this.apiToken
Otherwise it shows null in the action name....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @ThatGalNatalie
PR Checklist:
CHANGELOG.md
Describe this PR
apiToken
indisableNext
andallowSave
Remove requirement to add an API Secret for Pager Duty actions #1051