Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement to add an API Secret for Pager Duty #1065

Merged
merged 8 commits into from
Sep 29, 2021

Conversation

ThatGalNatalie
Copy link
Contributor

@ThatGalNatalie ThatGalNatalie commented Sep 28, 2021

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

@ThatGalNatalie ThatGalNatalie marked this pull request as ready for review September 28, 2021 18:14
@ThatGalNatalie ThatGalNatalie linked an issue Sep 28, 2021 that may be closed by this pull request
1 task
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks @ThatGalNatalie

This isn't actually from your PR but in line https://github.com/PrefectHQ/ui/pull/1065/files#diff-3af46aeb97e3ab5dfecf9ff91442aa60a6bfd556c5f1b40ea61a760ffdfc3334R178

Could we add a check for apiToken?
E.g.

const whoTo = this.actionConfigArray.length
          ? this.actionConfigArray
          : this.secretName || this.webhookURLString || this.apiToken
          

Otherwise it shows null in the action name....

Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThatGalNatalie ThatGalNatalie merged commit ad555de into master Sep 29, 2021
@ThatGalNatalie ThatGalNatalie deleted the issue-1051 branch September 29, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove requirement to add an API Secret for Pager Duty actions
2 participants