Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global max width #1026

Merged
merged 7 commits into from
Sep 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Features and Improvements

- Remove global max width on dashboard etc screens - [#1026](https://github.com/PrefectHQ/ui/pull/1026)
- Route to task run page on timeline click - [#1024](https://github.com/PrefectHQ/ui/pull/1024)
- Remove references to unused task attributes - [#1011](https://github.com/PrefectHQ/ui/pull/1011)

Expand Down
1 change: 0 additions & 1 deletion src/components/NavTabBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ export default {
$vuetify.breakpoint.smAndDown ? 'tabs-hidden' : '',
pageScrolled ? 'elevation-4' : ''
]"
style="max-width: 1440px;"
>
<v-tabs-slider color="blue"></v-tabs-slider>
<template v-for="tb in mainTabs">
Expand Down
3 changes: 1 addition & 2 deletions src/layouts/SubPageNav.vue
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ export default {
:class="{
'justify-center': $vuetify.breakpoint.smAndDown
}"
style="height: 64px;
max-width: 1440px;"
style="height: 64px;"
>
<v-col :sm="$slots['page-actions'] ? 6 : 12" class="d-flex align-end">
<div class="mr-2">
Expand Down
4 changes: 2 additions & 2 deletions src/layouts/TileLayout-Alternate.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<v-container fluid style="max-width: 1440px;" class="mx-auto pt-0 px-3 pb-12">
<v-sheet fluid color="transparent" class="mx-auto pt-0 px-3 pb-12">
<v-row no-gutters>
<v-col cols="12" md="4" class="py-0">
<v-row v-if="$slots['col-1-tile-1']" class="justify-start">
Expand Down Expand Up @@ -87,5 +87,5 @@
</v-row>
</v-col>
</v-row>
</v-container>
</v-sheet>
</template>
4 changes: 2 additions & 2 deletions src/layouts/TileLayout-Full.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<v-container style="max-width: 1440px;" class="pt-0 pb-12">
<v-sheet color="transparent" class="pt-0 pb-12">
<v-row v-if="$slots['row-1-tile']" no-gutters>
<v-col cols="12" class="pb-0">
<v-row>
Expand All @@ -21,5 +21,5 @@
</v-row>
</v-col>
</v-row>
</v-container>
</v-sheet>
</template>
1 change: 0 additions & 1 deletion src/pages/Agents/AgentPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ export default {
<v-tabs-items
v-model="tab"
class="px-6 mx-auto tabs-border-bottom tab-full-height"
style="max-width: 1440px;"
:style="{
'padding-top': $vuetify.breakpoint.smOnly ? '30px' : '80px'
}"
Expand Down
3 changes: 0 additions & 3 deletions src/pages/Dashboard/Dashboard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,6 @@ export default {
<v-tabs-items
v-model="tab"
class="px-6 mx-auto tabs-border-bottom tab-full-height"
style="
max-width: 1440px;
"
:style="{
'padding-top': $vuetify.breakpoint.smOnly ? '80px' : '130px'
}"
Expand Down
1 change: 0 additions & 1 deletion src/pages/Flow/Flow.vue
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,6 @@ export default {
v-model="tab"
v-if="flowGroup"
class="px-6 mx-auto tabs-border-bottom tab-full-height"
style="max-width: 1440px;"
:style="{
'padding-top': $vuetify.breakpoint.smOnly ? '80px' : '130px'
}"
Expand Down
1 change: 0 additions & 1 deletion src/pages/FlowRun/FlowRun.vue
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@ export default {
v-model="tab"
class="px-6 mx-auto tabs-border-bottom tab-full-height"
:style="{
'max-width': tab == 'chart' ? 'auto' : '1440px',
'padding-top': $vuetify.breakpoint.smOnly ? '80px' : '130px'
}"
mandatory
Expand Down
1 change: 0 additions & 1 deletion src/pages/Task/Task.vue
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ export default {
<v-tabs-items
v-model="tab"
class="px-6 mx-auto tabs-border-bottom tab-full-height"
style="max-width: 1440px;"
:style="
$vuetify.breakpoint.mdAndUp ? 'padding-top: 130px' : 'padding-top: 80px'
"
Expand Down
1 change: 0 additions & 1 deletion src/pages/TaskRun/TaskRun.vue
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,6 @@ export default {
<v-tabs-items
v-model="tab"
class="px-6 mx-auto tabs-border-bottom tab-full-height"
style="max-width: 1440px;"
:style="{
'padding-top': $vuetify.breakpoint.smOnly ? '80px' : '130px'
}"
Expand Down