-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor "installing" resources to ~/.ptx
#758
Conversation
Now all static files are installed to the disk at |
implemented to make #745 less of headache |
Also we just dump everything from the core pretext repo into that folder. That means we have access to things like the sample article, which I might write a test for... |
It appears that the sample article uses https://github.com/PreTeXtBook/pretext/blob/ac1ca3ca67c9512059afd6fd37a714a7fc988a5d/pretext/pretext.py#L1034 but we haven't implemented it. @rbeezer which part of the sample article uses this feature? |
Ah I see this is reverted at ac1ca3ca67c9512059afd6fd37a714a7fc988a5d |
@dbrianwalton we'll need an update to this repo to get your dynamic exercises working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not read all of the code carefully, but I mostly agree with what you are trying to do here and trust that you have tested this sufficiently.
My only concern is that if we keep multiple versions of the .ptx resources (for different versions), then we will have lots of copies of the sample article. Just a little worried about filesize.
Okay, also one more thing: there should be an easy way to refresh the resources in case they get corrupted some how.
|
An issue with packaging this: the relocated zip files aren't being grabbed... |
No description provided.