Migrate to godot 4 #18

Kvel2D · 2023-03-04T12:31:25Z

Unresolved issues:

Tilemap is broken (https://github.com/tlobig/convert_gd3_togd4_tilemaps maybe this will help)
Some HUD elements have layout or sizing problems
Selection.draw() is not ported
GroupingTilemap is not ported

Useful link listing all of the things that converter does incorrectly:
godotengine/godot#73960

Praytic · 2023-03-04T18:10:50Z

_ready() doesn't implicitly call parent version anymore, had to add explicit calls to super() or rework initialization in case of items and towers.

Answer:

This is intentional, and fixed an inconsistency in the OOP behavior of Godot 3.

If you want to call the parent method, you should use super() in the method that overrides it.

godotengine/godot#73377

New directory in godot 4

Add new font import This was done by opening upgraded project in editor for the first time

Editor said that scene is "broken" when opening it for the first time Had to remake by hand

By opening them in editor for the first time

String ctor with int parameter was removed in godot 4

Those are built-in functions so rename our functions to avoid \ overriding them

Add calls to super() Add spaces between parameters

Fix later Remove tween nodes

Reconnect element_changed signal Fix mixed tab/spaces

Zoom values were inverted in godot 4

Fix later

In godot 3, parent class _ready() was implicitly called This is not the case for godot 4 anymore Add explicit calls to _ready() For towers and items, add separate init functions to avoid mistakes \ around forgetting super() calls in tower/item scripts

By opening in editor for the first time

font_size was added in godot 4

Use width not height and divide by 4 not 2

Praytic · 2023-03-05T13:29:06Z

Tilemap is broken

Autotiles cannot be converted automatically: godotengine/godot#64006

To ui_accept and ui_cancel

Modify FloatingText tweens slightly

Don't need to call randomize() randi_range() was added to godot 4

Restore original animation speed Scale down pulse texture Fix tower preview modulate applying to range indicator as well, \ apply it only to tower visual

YSort was removed in godot 4 Turn on y_sort_enabled for MobYSort node to approximate old effect

Migrate to godot 4

Kvel2D added 20 commits March 5, 2023 07:28

Add .godot to gitignore

727bbee

New directory in godot 4

Run project upgrade tool

96f2006

Update project.godot by opening the editor

34b3990

Update imports

d8ea9de

Add new font import This was done by opening upgraded project in editor for the first time

Fix Explosion.tscn

e893212

Editor said that scene is "broken" when opening it for the first time Had to remake by hand

Update .tscn and .tres files

2fa4bde

By opening them in editor for the first time

Update String() to str()

9c342ee

String ctor with int parameter was removed in godot 4

Switch to Geometry2D

e988c63

Switch to FileAccess and DirAccess

d7b00ca

Switch to TileMap.get_cell_source_id()

95e39d3

Fix errors about get_owner() and get_name()

4758ad5

Those are built-in functions so rename our functions to avoid \ overriding them

Fix _init() calls

46dbf98

Add calls to super() Add spaces between parameters

Update Gamescene.tscn

f240fd8

Comment out GroupingTileMap.get_used_rect()

215dcf8

Switch to using get_screen_center_position()

adf99f5

Comment out outdated tween code

da13bbe

Fix later Remove tween nodes

Update json parsing

359d023

Print file open errors

c9a7f09

update() -> queue_redraw()

0949d16

get_extents() -> size

ab23c4a

Kvel2D force-pushed the migrate-to-godot-4 branch from c6ae5fe to ab23c4a Compare March 5, 2023 07:22

Kvel2D added 8 commits March 5, 2023 08:24

Fix export var error

8d45539

Fix tower buttons

0d5d8f4

Reconnect element_changed signal Fix mixed tab/spaces

Turn fullscreen back on

26f735f

Fix zoom being inverted

df1db8c

Fix input map

4fc1fc4

Make camera less zoomed in on startup

787a0dc

Zoom values were inverted in godot 4

Comment out Selection code

49bd290

Fix later

Kvel2D added 6 commits March 5, 2023 08:44

Fix the rest of input map

0d783ad

Update wc3_theme

d7420e6

By opening in editor for the first time

Set default font size for wc3_theme

d0b773f

font_size was added in godot 4

Automatic updates for HUD scenes

db49517

Fix size_limit of small atlas textures

b161872

Fix tower_icons_s size_limit

68b051b

Use width not height and divide by 4 not 2

Praytic and others added 4 commits March 5, 2023 06:44

Fix layout of HUD elements

293ba44

Add bindings for LMB and RMB

7ca2be9

To ui_accept and ui_cancel

Fix projectile sprite

74ae4aa

Update tweens to new API

e6a888a

Modify FloatingText tweens slightly

Kvel2D force-pushed the migrate-to-godot-4 branch from f1bb2fe to e6a888a Compare March 5, 2023 16:56

Kvel2D and others added 9 commits March 5, 2023 20:10

Update randomization

565db42

Don't need to call randomize() randi_range() was added to godot 4

Fix warnings

9cd513b

Reimport tileset assets

5bd9a57

Remove alternative tiles from the Dungeon tileset

8c4dfd2

Fix tilemap props

16e75d5

Change tile size

48dbbaf

Restore one island with the Floor

cd61132

Fix range indicator

71fbf50

Restore original animation speed Scale down pulse texture Fix tower preview modulate applying to range indicator as well, \ apply it only to tower visual

Fix MobYSort

c6490bd

YSort was removed in godot 4 Turn on y_sort_enabled for MobYSort node to approximate old effect

Kvel2D marked this pull request as ready for review March 6, 2023 18:50

Kvel2D merged commit 2547641 into main Mar 6, 2023

Kvel2D deleted the migrate-to-godot-4 branch March 7, 2023 07:11

Praytic pushed a commit that referenced this pull request Mar 27, 2023

Merge pull request #18 from Praytic/migrate-to-godot-4

ffefc33

Migrate to godot 4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to godot 4 #18

Migrate to godot 4 #18

Kvel2D commented Mar 4, 2023 •

edited

Loading

Praytic commented Mar 4, 2023

Praytic commented Mar 5, 2023 •

edited

Loading

Migrate to godot 4 #18

Migrate to godot 4 #18

Conversation

Kvel2D commented Mar 4, 2023 • edited Loading

Praytic commented Mar 4, 2023

Praytic commented Mar 5, 2023 • edited Loading

Kvel2D commented Mar 4, 2023 •

edited

Loading

Praytic commented Mar 5, 2023 •

edited

Loading