Fix helm-vault secret decryption #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luisdavim - Is there any ETA on a release that will include this fix? |
|
I can look into cutting a release today. |
|
Thanks mate |
mkubaczyk
pushed a commit
that referenced
this pull request
Aug 18, 2023
Co-authored-by: Ben Bettridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #758
helm-vaultdoes not support outputting secrets to stdout, souseHelmOutputis set tofalsehelm-vaultinterpolates the environment variable name into the output file if one is specified, so an additional step of renaming the file to the expected name is addedhelm-vaultoutputs the expected file by default (original file name with.decappended) if no environment is specified. No changes required to handle this case other than settingsuseHelmOutputtofalse