-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made a new stylesheet files #61
Conversation
… to respective file
@PragatiVerma18, Kindly review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please attach some screenshots so as to give an idea of the style changes, if any.
@PragatiVerma18, I did not change anything. I literally copied all styles that were written in the HTML file to the new CSS file and link them. As style and script should not be in the HTML file. I just made the directory and file structure better. Nothing else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please push the changes to the nwoc
branch to get it merged.
@PragatiVerma18, I have changed the base branch. Kindly merge with the SWoC label. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for dropping this PR.
Congrats on merging your first pull request! 🎉 All the best for your amazing open source journey ahead 🚀. |
Issue that resolved:
#60
Solution:
Put all styles in a separate file for better readability and directory structure.