Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made a new stylesheet files #61

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Made a new stylesheet files #61

merged 1 commit into from
Jan 25, 2021

Conversation

sagarpandyansit
Copy link

Issue that resolved:
#60

Solution:
Put all styles in a separate file for better readability and directory structure.

@sagarpandyansit
Copy link
Author

@PragatiVerma18, Kindly review it.

Copy link
Owner

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach some screenshots so as to give an idea of the style changes, if any.

@sagarpandyansit
Copy link
Author

@PragatiVerma18, I did not change anything. I literally copied all styles that were written in the HTML file to the new CSS file and link them. As style and script should not be in the HTML file. I just made the directory and file structure better. Nothing else.

Copy link
Owner

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please push the changes to the nwoc branch to get it merged.

@sagarpandyansit sagarpandyansit changed the base branch from all-contributors/add-adad20 to nwoc January 21, 2021 10:47
@sagarpandyansit
Copy link
Author

@PragatiVerma18, I have changed the base branch. Kindly merge with the SWoC label. Thanks.

Copy link
Owner

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for dropping this PR.

@PragatiVerma18 PragatiVerma18 merged commit defcc1c into PragatiVerma18:nwoc Jan 25, 2021
@welcome
Copy link

welcome bot commented Jan 25, 2021

Congrats on merging your first pull request! 🎉 All the best for your amazing open source journey ahead 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SWOC SWoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants