Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSQLServer: New version 4.0.7 of Pester will break unit tests #807

Closed
johlju opened this issue Sep 13, 2017 · 2 comments · Fixed by #828
Closed

xSQLServer: New version 4.0.7 of Pester will break unit tests #807

johlju opened this issue Sep 13, 2017 · 2 comments · Fixed by #828
Assignees
@johlju
Labels
bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented Sep 13, 2017

Details of the scenario you tried and the problem that is occurring:
The new release of Pester, version 4.0.7 will break unit tests in this repository. Either we fix what breaks or we revert back to an older version. I really see we fix the breaking changes.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Sep 13, 2017
@johlju
Copy link
Member Author

johlju commented Sep 13, 2017

There is a bunch of unit tests that failed now with the new release of Pester.
https://ci.appveyor.com/project/PowerShell/xsqlserver/build/6.0.1578.0

@johlju
Copy link
Member Author

johlju commented Sep 13, 2017

List of changes:
https://github.com/pester/Pester/releases/tag/4.0.7

johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 14, 2017
@johlju
Changes to xSQLServer
8894614 
- Changed so the maximum version to be installed is 4.0.6.0. Quick fix until we
  can resolve the unit tests (see issue dsccommunity#807).
@johlju johlju mentioned this issue Sep 14, 2017
Merged
5 tasks
johlju added a commit that referenced this issue Sep 14, 2017
@johlju
xSQLServer: Quick fix for breaking changes in Pester (#813)
97af610 
- Changes to xSQLServer
  - Changed so the maximum version to be installed is 4.0.6.0. Quick fix until we
    can resolve the unit tests (see issue #807).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 19, 2017
@johlju
Changes to xSQLServer
ef15399 
- Fix problem with tests breaking with Pester 4.0.7 (issue dsccommunity#807).
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Sep 19, 2017
@johlju johlju self-assigned this Sep 19, 2017
@johlju johlju mentioned this issue Sep 19, 2017
Merged
5 tasks
johlju added a commit that referenced this issue Sep 19, 2017
@johlju
xSQLServer: Fix problem with tests breaking with Pester 4.0.7 (#828)
fd76e7f 
- Changes to xSQLServer
  - Fix problem with tests breaking with Pester 4.0.7 (issue #807).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xSQLServer: Fix problem with tests breaking with Pester 4.0.7 johlju/SqlServerDsc
1 participant
@johlju