Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSQLServer: New Pester version released to PowerShell Gallery breaks tests #773

Closed
johlju opened this issue Aug 18, 2017 · 0 comments · Fixed by #777
Closed

xSQLServer: New Pester version released to PowerShell Gallery breaks tests #773

johlju opened this issue Aug 18, 2017 · 0 comments · Fixed by #777
Assignees
@johlju
Labels
bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented Aug 18, 2017 •
edited
Loading

The new Pester version used CmdLetBinding which results in that we are getting errors where we incorrectly used wrong parameters or made typos.

For example a lot of hits on this error

ParameterBindingException: A parameter cannot be found that matches parameter name 'Scope'.

It's because Scope was used in the Mock command.

Mock -CommandName Connect-SQL -MockWith $mockConnectSqlVersion12 -Verifiable -Scope It
@johlju johlju added blocking release The issue or pull request is blocking the next release. Higher priority than label 'High priority'. bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. easy fix in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Aug 18, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Aug 18, 2017
@johlju
Changes to xSQLServer
d0258e2 
- Fixed typos and the use of wrong parameters in unit tests which was
  found after release of new version of Pester (issue dsccommunity#773).
@johlju johlju mentioned this issue Aug 18, 2017
Merged
5 tasks
johlju added a commit that referenced this issue Aug 19, 2017
@johlju
xSQLServer: Fixed typos and use of wrong parameters in unit tests (#777)
4734f66 
- Changes to xSQLServer
  - Fixed typos and the use of wrong parameters in unit tests which was
    found after release of new version of Pester (issue #773).
@vors vors removed the blocking release The issue or pull request is blocking the next release. Higher priority than label 'High priority'. label Aug 19, 2017
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xSQLServer: Fixed typos and the use of wrong parameters in unit tests johlju/SqlServerDsc
2 participants
@vors @johlju